Skip to content

[Types] rename-aliases#7288

Draft
keithharvey wants to merge 1 commit into
beyond-all-reason:fmtfrom
keithharvey:mig-rename-aliases
Draft

[Types] rename-aliases#7288
keithharvey wants to merge 1 commit into
beyond-all-reason:fmtfrom
keithharvey:mig-rename-aliases

Conversation

@keithharvey

@keithharvey keithharvey commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Part of BAR type-error cleanup. Rebuilds idempotently from master via just bar::fmt-mig-generate.

What it does: Renames deprecated Spring method aliases to their canonical names (e.g. Spring.GetMyTeamID → Spring.GetLocalTeamID) so call sites line up with the names the engine type stubs declare.

# rename-aliases -- deprecated aliases, e.g. GetMyTeamID -> GetLocalTeamID
bar-lua-codemod rename-aliases --path "$BAR_DIR" --exclude common/luaUtilities

Branch Topology

All branches in the BAR type-error cleanup stack. Regenerated deterministically by just bar::fmt-mig-generate. Generated 2026-06-11 10:24:48 UTC.

Leaves — each targets master, mergeable independently:

Branch Command Diff vs parent Units
fmt stylua 1450 files, +183025 −187662 ✅ pass
mig-bracket bar-lua-codemod bracket-to-dot 342 files, +7653 −7653 ✅ pass
mig-rename-aliases bar-lua-codemod rename-aliases 173 files, +362 −362 ✅ pass
mig-detach-bar-modules bar-lua-codemod detach-bar-modules 178 files, +1694 −1562 ✅ pass
mig-i18n bar-lua-codemod i18n-kikito 20 files, +121 −1198 ✅ pass
mig-spring-split bar-lua-codemod spring-split 782 files, +10019 −10010 ✅ pass
mig-integration-tests <hand curated> 22 files, +140 −90 ✅ pass
mig-busted-types <hand curated> 12 files, +1501 −0 ✅ pass

Rollups — composite branches stacking the leaves and (for fmt-llm) the env + LLM layers:

Branch Diff vs master Diff vs parent Units
mig 1480 files, +193205 −197222 897 files, +21353 −20733 ✅ pass
fmt-llm-source 1486 files, +193710 −197492 55 files, +575 −340 ✅ pass
fmt-llm 1487 files, +193804 −197514 51 files, +117 −45 ✅ pass

@github-actions

github-actions Bot commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Integration Test Results

14 tests   6 ✅  3s ⏱️
 1 suites  8 💤
 1 files    0 ❌

Results for commit a375b59.

♻️ This comment has been updated with latest results.

This was referenced Mar 31, 2026
Open
Draft
Draft
Draft
This was referenced Mar 31, 2026
Draft
Draft
@keithharvey keithharvey force-pushed the mig-rename-aliases branch 4 times, most recently from c6b541e to 9fa59d3 Compare April 1, 2026 21:46
@keithharvey keithharvey marked this pull request as ready for review April 1, 2026 21:51
@keithharvey keithharvey force-pushed the mig-rename-aliases branch 3 times, most recently from 60b899e to 0b4b49b Compare April 3, 2026 19:27
@keithharvey keithharvey marked this pull request as draft April 3, 2026 19:31
@keithharvey keithharvey force-pushed the mig-rename-aliases branch 4 times, most recently from 4db1750 to 3ed3c13 Compare April 4, 2026 16:51
@keithharvey keithharvey mentioned this pull request Apr 11, 2026
Draft
@keithharvey keithharvey force-pushed the mig-rename-aliases branch 6 times, most recently from c413421 to 815c749 Compare April 12, 2026 16:42
@keithharvey keithharvey force-pushed the mig-rename-aliases branch from e724011 to 5a6dbfd Compare June 9, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@keithharvey